Introduce new extended attribute grammars #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These new grammars will be used by the HTML spec for attribute reflection extended attributes.
6 tasks
domenic
approved these changes
Jul 15, 2025
Yeah I think it makes sense to wait until at least the non-enum IDL reflection stuff is agreed upon. That uses all 3 of these new grammars. |
lukewarlow
commented
Jul 15, 2025
…edAttributeDecimal
lukewarlow
changed the title
This was referenced Jul 17, 2025
|
I think this is ready to go now. The python parser has been updated which I think is the main blocker. It seems the HTML PR is ready to go so these new grammars will end up being used. |
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Jul 30, 2025
A number of extended attributes are added which trigger IDL attribute reflection: - [Reflect] and [Reflect=string] cover basic content attribute reflection cases. - [ReflectSetter] and [ReflectSetter=string] covers content attribute reflection only for setters. - [ReflectURL] and [ReflectURL=string] covers reflection of USV attributes, which represent URLs. - [ReflectNonNegative] and [ReflectNonNegative=string] covers reflection of long attributes that should be limited to only non-negative numbers. - [ReflectPositive] and [ReflectPositive=string] covers reflection of double and unsigned long attributes which should be limited to positive numbers. - [ReflectPositiveWithFallback] and [ReflectPositiveWithFallback=string] covers reflection of double and unsigned long attributes which should be limited to positive numbers with fallback. Additionally: - [ReflectRange=(integer, integer)] can be used alongside others on unsigned long attributes that should be clamped to a range. - [ReflectDefault=number] can be used alongside others on double, long and unsigned long attributes that should be reflected with a default value. Corresponding Web IDL PR: whatwg/webidl#1503.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce four new extended attribute grammars
These new grammars will be used by the HTML spec for attribute reflection extended attributes. ExtendedAttributeString (
[Reflect="foo"]), ExtendedAttributeInteger ([ReflectDefault=1]), ExtendedAttributeDecimal ([ReflectDefault=1.0]) and ExtendedAttributeIntegerList ([ReflectRange=(1,100)]) are added.(See WHATWG Working Mode: Changes for more details.)
Preview | Diff